Add Electron Tau cross-trigger to the HLT Phase-2 menu #46924

rdewanje · 2024-12-12T11:48:53Z

PR description:

Added the Electron+Tau cross trigger path to the existing Phase-2 HLT Menu after following the recipe given here:
https://cmshltupgrade.docs.cern.ch/RunningInstructions/

PR validation:

PR passed all test mentioned here:
https://cms-sw.github.io/PRWorkflow.html

cmsbuild · 2024-12-12T11:49:15Z

cms-bot internal usage

cmsbuild · 2024-12-12T11:52:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46924/42986

cmsbuild · 2024-12-12T11:52:43Z

A new Pull Request was created by @rdewanje for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich

Please update the PR title to be meaningful (as in "Add Electron Tau cross-trigger to the HLT Phase-2 menu")

mmusich · 2024-12-12T11:54:36Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+from ..sequences.HLTPFTauHPS_cfi import *
+from ..sequences.HLTHPSDeepTauPFTauSequence_cfi import *
+
+#from ..sequences.RawToDigiSequence_cfi import *  ## CHANGED TO FILE BELOW


Suggested change

#from ..sequences.RawToDigiSequence_cfi import * ## CHANGED TO FILE BELOW

mmusich · 2024-12-12T11:54:44Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+#from ..sequences.RawToDigiSequence_cfi import *  ## CHANGED TO FILE BELOW
+from ..sequences.HLTRawToDigiSequence_cfi import *
+
+#from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW


Suggested change

#from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW

mmusich · 2024-12-12T11:54:51Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+#from ..sequences.hgcalLocalRecoSequence_cfi import * ## CHANGED TO FILE BELOW
+from ..sequences.HLTHgcalLocalRecoSequence_cfi import *
+
+#from ..sequences.localrecoSequence_cfi import * ## CHANGED TO FILE BELOW


Suggested change

#from ..sequences.localrecoSequence_cfi import * ## CHANGED TO FILE BELOW

mmusich · 2024-12-12T11:55:20Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+
+
+
+#hltEG30EtL1SeededFilter = _hltEG32EtL1SeededFilter.clone(
+#    etcutEB = cms.double(30.0), 
+#    etcutEE = cms.double(30.0), 
+#    inputTag = cms.InputTag("hltEgammaCandidatesWrapperL1Seeded"),
+#    l1EGCand = cms.InputTag("hltEgammaCandidatesL1Seeded"),
+#    ncandcut = cms.int32(1),
+#    saveTags = cms.bool(True)
+#)


Suggested change

#hltEG30EtL1SeededFilter = _hltEG32EtL1SeededFilter.clone(

# etcutEB = cms.double(30.0),

# etcutEE = cms.double(30.0),

# inputTag = cms.InputTag("hltEgammaCandidatesWrapperL1Seeded"),

# l1EGCand = cms.InputTag("hltEgammaCandidatesL1Seeded"),

# ncandcut = cms.int32(1),

# saveTags = cms.bool(True)

#)

mmusich · 2024-12-12T11:55:40Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+    HLTBeginSequence +
+    hltPuppiTauTkIsoEle4522L1TkFilter +
+
+    #RawToDigiSequence +


Suggested change

#RawToDigiSequence +

mmusich · 2024-12-12T11:55:46Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+    #RawToDigiSequence +
+    HLTRawToDigiSequence +
+
+    #hgcalLocalRecoSequence +


Suggested change

#hgcalLocalRecoSequence +

mmusich · 2024-12-12T11:55:54Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+    #hgcalLocalRecoSequence +
+    HLTHgcalLocalRecoSequence +
+
+    #localrecoSequence +


Suggested change

#localrecoSequence +

mmusich · 2024-12-12T11:56:56Z

HLTrigger/Configuration/python/HLT_75e33_cff.py

@@ -404,7 +405,7 @@
    fragment.HLT_DoubleMediumChargedIsoPFTauHPS40_eta2p1,
    fragment.HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1,
    fragment.HLT_IsoMu20_eta2p1_LooseDeepTauPFTauHPS27_eta2p1_CrossL1,
-
+    fragment.HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1,


please add this trigger also in the timing variant of the menu at HLTrigger/Configuration/python/HLT_75e33_timing_cff.py

I have added this E-Tau path to the HLT_75e33_timing_cff.py file

mmusich · 2024-12-12T11:58:46Z

test parameters:

enable = hlt_p2_integration
enable = hlt_p2_timing

mmusich · 2024-12-13T08:47:36Z

@rdewanje please clarify if there will be follow-ups to the review. In particular addressing #46924 (comment) is necessary before starting tests.

rovere · 2024-12-13T13:33:42Z

Dear all, unless this new cross trigger path is added also to the timing flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

mmusich · 2024-12-13T13:34:57Z

Dear all, unless this new cross trigger path is added also to the trigger flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

that's precisely my comment at #46924 (comment) and #46924 (comment) @rdewanje

rovere · 2024-12-13T13:36:03Z

Dear all, unless this new cross trigger path is added also to the trigger flavour of the Phase-2 HLT menu, the timing measurements will be irrelevant/useless.

that's precisely my comment at #46924 (comment) and #46924 (comment) @rdewanje

thanks Marco! Repetita iuvant. Sorry for the noise.

rovere · 2024-12-16T09:32:52Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+from ..modules.hltAK4PFJetsForTaus_cfi import *
+from ..modules.hltHpsSelectedPFTauLooseTauWPDeepTau_cfi import * 
+from ..modules.hltHpsPFTau30LooseTauWPDeepTau_cfi import * ## NEW (with threshold different from youngwan)
+from ..modules.hltAK4PFJets_cfi import *


I think the module imported from this line is never used. I'd suggest to verify if that's correct and, if so, remove the import.

Indeed, the line "from hltAK4PFJets_cfi import *" has been removed from the cfi file for the E-Tau path

rovere · 2024-12-16T09:33:36Z

HLTrigger/Configuration/python/HLT_75e33/modules/hltPuppiTauTkIsoEle4522L1TkFilter_cfi.py

@@ -0,0 +1,5 @@
+import FWCore.ParameterSet.Config as cms
+
+hltPuppiTauTkIsoEle4522L1TkFilter = cms.EDFilter("PathStatusFilter",


I'd suggest to change the name of the module and of the files by adding an underscore between 45 and 22.

@rdewanje now this file is completely superseded by HLTrigger/Configuration/python/HLT_75e33/modules/hltPuppiTauTkIsoEle45_22L1TkFilter_cfi.py.
Please delete it and squash the commits in order to avoid having "virtual" files in the git history.

…sted changes to the E-Tau path files

cmsbuild · 2024-12-16T11:57:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46924/43030

cmsbuild · 2024-12-16T11:58:05Z

Pull request #46924 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

rdewanje · 2024-12-16T11:59:26Z

Please update the PR title to be meaningful (as in "Add Electron Tau cross-trigger to the HLT Phase-2 menu")

Done.

rdewanje · 2024-12-16T12:00:49Z

@rdewanje please clarify if there will be follow-ups to the review. In particular addressing #46924 (comment) is necessary before starting tests.

All comments regarding the PR have been addressed.

cmsbuild · 2024-12-16T14:13:36Z

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cde003/43470/summary.html
COMMIT: 4bcc213
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46924/43470/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.
HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3510017
DQMHistoTests: Total failures: 489
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3509508
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 1 / 44 workflows

mmusich · 2024-12-17T10:30:56Z

...thon/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py

+from ..modules.hltHpsPFTau30LooseTauWPDeepTau_cfi import *
+
+
+hltEle30WPTightClusterShapeL1SeededFilter = _hltEle32WPTightClusterShapeL1SeededFilter.clone(


for this module and all of the others below, I don't think that cloning an existing piece of configuration and then modifying a parameter from within the path itself is something we did elsewhere in the HLT menu.
I would actually create a new cfi file in HLTrigger/Configuration/python/HLT_75e33/modules

But these additional files will cost additional memory. Besides it was recommended here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookConfigFileIntro#ClonIng

But these additional files will cost additional memory.

I am not sure to see the point. Why would this cost additional memory?

Besides it was recommended here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookConfigFileIntro#ClonIng

while this is fine for general purposes, it's not the structure we decided to adopt for the phase-2 HLT menu. Please comply.

@rdewanje please clarify if you are going to follow-up to #46924 (comment)

…PuppiTauTkIsoEle4522L1TkFilter_cfi.py

cmsbuild · 2024-12-17T11:38:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46924/43051

Found files with invalid states:
- HLTrigger/Configuration/python/HLT_75e33/modules/hltPuppiTauTkIsoEle4522L1TkFilter_cfi.py:
  - Added: d881ffc
  - Deleted: 9ad6dc2

cmsbuild · 2024-12-17T11:39:05Z

Pull request #46924 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

rdewanje · 2024-12-19T17:58:09Z

I am currently traveling. Will follow up on the comments this weekend. Get Outlook for Android<https://aka.ms/AAb9ysg>

________________________________ From: Marco Musich ***@***.***> Sent: Thursday, December 19, 2024 7:27:22 PM To: cms-sw/cmssw ***@***.***> Cc: Ram Krishna Dewanjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Add Electron Tau cross-trigger to the HLT Phase-2 menu (PR #46924) @mmusich commented on this pull request.

________________________________ In HLTrigger/Configuration/python/HLT_75e33/paths/HLT_Ele30_WPTight_L1Seeded_LooseDeepTauPFTauHPS30_eta2p1_CrossL1_cfi.py<#46924 (comment)>:

+from ..modules.hltEle32WPTightPMS2L1SeededFilter_cfi import hltEle32WPTightPMS2L1SeededFilter as _hltEle32WPTightPMS2L1SeededFilter

+from ..modules.hltEle32WPTightGsfOneOEMinusOneOPL1SeededFilter_cfi import hltEle32WPTightGsfOneOEMinusOneOPL1SeededFilter as _hltEle32WPTightGsfOneOEMinusOneOPL1SeededFilter +from ..modules.hltEle32WPTightGsfDetaL1SeededFilter_cfi import hltEle32WPTightGsfDetaL1SeededFilter as _hltEle32WPTightGsfDetaL1SeededFilter +from ..modules.hltEle32WPTightGsfDphiL1SeededFilter_cfi import hltEle32WPTightGsfDphiL1SeededFilter as _hltEle32WPTightGsfDphiL1SeededFilter +from ..modules.hltEle32WPTightBestGsfNLayerITL1SeededFilter_cfi import hltEle32WPTightBestGsfNLayerITL1SeededFilter as _hltEle32WPTightBestGsfNLayerITL1SeededFilter +from ..modules.hltEle32WPTightBestGsfChi2L1SeededFilter_cfi import hltEle32WPTightBestGsfChi2L1SeededFilter as _hltEle32WPTightBestGsfChi2L1SeededFilter +from ..modules.hltEgammaEleL1TrkIsoL1Seeded_cfi import * +from ..modules.hltEle32WPTightGsfTrackIsoFromL1TracksL1SeededFilter_cfi import hltEle32WPTightGsfTrackIsoFromL1TracksL1SeededFilter as _hltEle32WPTightGsfTrackIsoFromL1TracksL1SeededFilter +from ..modules.hltEgammaEleGsfTrackIsoV6L1Seeded_cfi import * +from ..modules.hltEle32WPTightGsfTrackIsoL1SeededFilter_cfi import hltEle32WPTightGsfTrackIsoL1SeededFilter as _hltEle32WPTightGsfTrackIsoL1SeededFilter +from ..modules.hltAK4PFJetsForTaus_cfi import * +from ..modules.hltHpsSelectedPFTauLooseTauWPDeepTau_cfi import * +from ..modules.hltHpsPFTau30LooseTauWPDeepTau_cfi import * + + +hltEle30WPTightClusterShapeL1SeededFilter = _hltEle32WPTightClusterShapeL1SeededFilter.clone( @rdewanje<https://github.com/rdewanje> please clarify if you are going to follow-up to #46924 (comment)<#46924 (comment)> — Reply to this email directly, view it on GitHub<#46924 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAPZKEAVP6TXJKWRD5P443L2GLGEFAVCNFSM6AAAAABTPTLDPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJUHAYDEMRZGM>. You are receiving this because you were mentioned.Message ID: ***@***.***>

…r/Configuration/python/HLT_75e33/modules directory as requested

cmsbuild · 2024-12-22T10:30:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46924/43138

Found files with invalid states:
- HLTrigger/Configuration/python/HLT_75e33/modules/hltPuppiTauTkIsoEle4522L1TkFilter_cfi.py:
  - Added: d881ffc
  - Deleted: 9ad6dc2

cmsbuild · 2024-12-22T10:31:06Z

Pull request #46924 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

mmusich · 2024-12-22T11:01:47Z

@cmsbuild, please test

cmsbuild · 2024-12-22T13:22:47Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cde003/43597/summary.html
COMMIT: 2cdafcc
CMSSW: CMSSW_15_0_X_2024-12-22-0000/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46924/43597/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3818730
DQMHistoTests: Total failures: 444
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3818266
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

rdewanje added 2 commits December 11, 2024 12:32

Added E-Tau Trigger path files

d881ffc

Added the E-Tau trigger in the HLT_75e33_cff.py file

ba6317d

cmsbuild added this to the CMSSW_15_0_X milestone Dec 12, 2024

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Dec 12, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2024

mmusich reviewed Dec 12, 2024

View reviewed changes

rovere reviewed Dec 16, 2024

View reviewed changes

rdewanje changed the title ~~Etau trigger pr branch~~ Add Electron Tau cross-trigger to the HLT Phase-2 menu Dec 16, 2024

Added E-tau trigger to HLT_75e33_timing_cff.py and made all the reque…

4bcc213

…sted changes to the E-Tau path files

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 16, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 16, 2024

cmsbuild added the tests-started label Dec 16, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2024

mmusich reviewed Dec 17, 2024

View reviewed changes

deleted the file HLTrigger/Configuration/python/HLT_75e33/modules/hlt…

9ad6dc2

…PuppiTauTkIsoEle4522L1TkFilter_cfi.py

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Dec 17, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 17, 2024

This was referenced Dec 17, 2024

clean-up unused inclusions in HLT paths in Phase2 HLT menu #46976

Merged

[Phase-2 L1] Incorporate object threshold scalings, ID and isolation via dictionaries into the P2GT menu #46489

Open

Moved all cloned modules to their respctive cfi files in the HLTrigge…

2cdafcc

…r/Configuration/python/HLT_75e33/modules directory as requested

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 22, 2024

cmsbuild added tests-started and removed tests-pending labels Dec 22, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 22, 2024

		@@ -0,0 +1,5 @@
		import FWCore.ParameterSet.Config as cms

		hltPuppiTauTkIsoEle4522L1TkFilter = cms.EDFilter("PathStatusFilter",

		from ..modules.hltHpsPFTau30LooseTauWPDeepTau_cfi import *


		hltEle30WPTightClusterShapeL1SeededFilter = _hltEle32WPTightClusterShapeL1SeededFilter.clone(

Add Electron Tau cross-trigger to the HLT Phase-2 menu #46924

Are you sure you want to change the base?

Add Electron Tau cross-trigger to the HLT Phase-2 menu #46924

Conversation

rdewanje commented Dec 12, 2024

PR description:

PR validation:

cmsbuild commented Dec 12, 2024 • edited Loading

cmsbuild commented Dec 12, 2024

cmsbuild commented Dec 12, 2024

mmusich left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmusich commented Dec 12, 2024 • edited Loading

mmusich commented Dec 13, 2024

rovere commented Dec 13, 2024 • edited Loading

mmusich commented Dec 13, 2024

rovere commented Dec 13, 2024

Choose a reason for hiding this comment

rdewanje Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

rdewanje commented Dec 16, 2024

rdewanje commented Dec 16, 2024

cmsbuild commented Dec 16, 2024

Comparison Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Dec 17, 2024

cmsbuild commented Dec 17, 2024

rdewanje commented Dec 19, 2024 via email

cmsbuild commented Dec 22, 2024

cmsbuild commented Dec 22, 2024

mmusich commented Dec 22, 2024

cmsbuild commented Dec 22, 2024

Comparison Summary

cmsbuild commented Dec 12, 2024 •

edited

Loading

mmusich left a comment •

edited

Loading

mmusich commented Dec 12, 2024 •

edited

Loading

rovere commented Dec 13, 2024 •

edited

Loading

rdewanje Dec 16, 2024 •

edited

Loading